From a11119d317206e5de4f34105685686b8bd602c71 Mon Sep 17 00:00:00 2001 From: Matthias Clasen Date: Sun, 10 May 2020 13:16:52 -0400 Subject: [PATCH] treeview: Ensure search popover is properly inserted The css tree and the widget tree are not in sync, so we need to explicitly set the parent of the css node before inserting the widget, or else we end up with critical warnings and a non-working popover. This can be seen in the print dialog, when moving the focus to the printer list. --- gtk/gtktreeview.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c index 2b3b46441c..9858400af6 100644 --- a/gtk/gtktreeview.c +++ b/gtk/gtktreeview.c @@ -9967,6 +9967,9 @@ gtk_tree_view_ensure_interactive_directory (GtkTreeView *tree_view) return; tree_view->search_popover = gtk_popover_new (); + gtk_css_node_insert_after (gtk_widget_get_css_node (GTK_WIDGET (tree_view)), + gtk_widget_get_css_node (tree_view->search_popover), + tree_view->header_node); gtk_widget_set_parent (tree_view->search_popover, GTK_WIDGET (tree_view)); gtk_popover_set_autohide (GTK_POPOVER (tree_view->search_popover), FALSE); -- 2.30.2